Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Demo improvements #2799

Merged
merged 16 commits into from Jan 25, 2019
Merged

[RFR] Demo improvements #2799

merged 16 commits into from Jan 25, 2019

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jan 22, 2019 •
edited

  • Add a two-level menu
  • Add a loader to the posters list
  • Generate invoices in the data generator
  • Add an Invoice list with expand
  • Display the Review detail on the side of the list
  • Use a normal Edit view on Mobile

localhost_3000_ 3

reviews

djhi
djhi reviewed Jan 22, 2019
View reviewed changes
examples/demo/src/invoices/InvoiceList.js Outdated

const InvoiceList = props => (
<List {...props} filters={<ListFilters />} perPage={25}>
<Datagrid expand={<ShowGuesser />}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the ShowGuesser does not allow you to override the title prop. It can be seen in the last screenshot: there are two titles concatenated (list and show) when expanding an line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the next commit. I only used the guesser temporarily.

@fzaninotto fzaninotto changed the title [WIP] Demo improvements [RFR] Demo improvements Jan 24, 2019
@fzaninotto fzaninotto added this to the 2.7.0 milestone Jan 24, 2019
@fzaninotto
Copy link
Member Author

Switching to RFR

alexisjanvier
alexisjanvier approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@alexisjanvier alexisjanvier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@alexisjanvier alexisjanvier merged commit a187c31 into next Jan 25, 2019
@alexisjanvier alexisjanvier deleted the invoices branch January 25, 2019 16:21
@fzaninotto fzaninotto mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi left review comments

@alexisjanvier alexisjanvier alexisjanvier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fzaninotto @alexisjanvier @djhi