Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix error when using Edit component as expand in list #2817

Merged
merged 2 commits into from
Jan 28, 2019
Merged

[RFR] Fix error when using Edit component as expand in list #2817

merged 2 commits into from
Jan 28, 2019

Conversation

fzaninotto
Copy link
Member

location isn't required at all.

Closes #2804

djhi
djhi approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also true for the CreateController and ShowController

@fzaninotto
Copy link
Member Author

good catch, I missed those.

@fzaninotto
Copy link
Member Author

It IS required in CreateController, so I left it there.

@fzaninotto fzaninotto added this to the v2.6.4 milestone Jan 28, 2019
@djhi djhi merged commit 47f7fdf into master Jan 28, 2019
@djhi djhi deleted the editcontroller-location-required branch January 28, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fzaninotto @djhi