[RFR] Fix AutocompleteInput by removing auto selection #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
force-pushed
the
fix-autocomplete-input
branch
from
b6d0210
to
3d88ed0
Compare
djhi
changed the title
djhi
changed the title
djhi
force-pushed
the
fix-autocomplete-input
branch
from
3d88ed0
to
caf03e9
Compare
fzaninotto
approved these changes
Jan 31, 2019
This was referenced Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue was that when used in a
ReferenceInput, whenever the filter changed, theAutocompleteInputfirst checked if one of the already available choices matched and if only one was found, it would not even try to fetch others from thedataProvider.As we also had numerous complaints about the auto-selection feature, we decided to remove it completely.
Fixes #2688, #2346