Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Unit Testing documentation #2872

Merged
merged 1 commit into from Feb 13, 2019
Merged

Update Unit Testing documentation #2872

merged 1 commit into from Feb 13, 2019

Conversation

mexitalian
Copy link
Contributor

The previous import location threw an error for me as it couldn't be found.

@mexitalian
Update UnitTesting.md
82b134a 
The previous import location threw an error for me as it couldn't be found.
@djhi
Copy link
Contributor

djhi commented Feb 12, 2019

The react-admin package just re-export what ra-core exports. So both imports should work

@Kmaschta
Copy link
Contributor

I somewhat agree with that PR: ra-core isn't documented (yet) and it might be confusing to the early adopters why we require that package in a simple unit test example.

@djhi djhi changed the title Update UnitTesting.md Update Unit Testing documentation Feb 13, 2019
@djhi djhi added this to the 2.7.2 milestone Feb 13, 2019
@djhi
Copy link
Contributor

djhi commented Feb 13, 2019

@fzaninotto What do you think about it? I agree with @Kmaschta

@fzaninotto fzaninotto merged commit eed959d into marmelab:master Feb 13, 2019
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mexitalian @djhi @Kmaschta @fzaninotto