Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Migrate ra-core controllers to TypeScript #2881

Merged
merged 13 commits into from
Feb 20, 2019
Merged

[RFR] Migrate ra-core controllers to TypeScript #2881

merged 13 commits into from
Feb 20, 2019

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Feb 13, 2019 •
edited
Loading

  • Fields
  • Inputs
  • Views

@djhi
[WIP] Migrate ra-core controllers to TypeScript
5fda66c 
- [x] Fields
- [ ] Inputs
- [ ] Views
@djhi djhi changed the title [WIP] Migrate ra-core controllers to TypeScript [RFR] Migrate ra-core controllers to TypeScript Feb 13, 2019
fzaninotto
fzaninotto requested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what happens with me, but I find the typed code more understandable than the untyped code. I must be sick or something.

packages/ra-core/src/controller/CreateController.tsx Show resolved Hide resolved
packages/ra-core/src/controller/CreateController.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/controller/EditController.tsx Show resolved Hide resolved
packages/ra-core/src/controller/ListController.tsx Show resolved Hide resolved
packages/ra-core/src/controller/ListController.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/controller/field/ReferenceManyFieldController.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/controller/input/ReferenceInputController.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/reducer/admin/references/oneToMany.ts Outdated Show resolved Hide resolved
packages/ra-core/src/reducer/admin/resource/list/params.ts Outdated Show resolved Hide resolved
packages/ra-core/src/types.ts Show resolved Hide resolved
@fzaninotto fzaninotto added this to the 2.7.2 milestone Feb 20, 2019
@fzaninotto fzaninotto merged commit eecedcc into master Feb 20, 2019
@fzaninotto
Copy link
Member

\o/

@djhi
Copy link
Contributor Author

djhi commented Feb 20, 2019

Wait before we test them. I'm sure we're going to be spanked hard by TS when using those definitions in the other packages 😰

@Kmaschta Kmaschta deleted the typescript-migration-controllers branch July 26, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djhi @fzaninotto