Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change SET_SORT reducer to accept a order value. #2921

Merged
merged 1 commit into from Mar 21, 2019
Merged

change SET_SORT reducer to accept a order value. #2921

merged 1 commit into from Mar 21, 2019

Conversation

frankPairs
Copy link
Contributor

new PR related to #2855

@djhi djhi added this to the 2.8.0 milestone Feb 24, 2019
@fzaninotto
Copy link
Member

This will be a pain to rebase because the files you've modified in next were migrated to TypeScript on master. So I'll wait until we rebase next on master and ask you to rebase your PR then.

@fzaninotto fzaninotto removed this from the 2.8.0 milestone Feb 25, 2019
@frankPairs
Copy link
Contributor Author

@fzaninotto ok, sounds good.

@djhi djhi added this to the 2.9.0 milestone Mar 15, 2019
@djhi
Copy link
Contributor

djhi commented Mar 15, 2019

The TypeScript migration has been merged into next too. Would you mind rebasing? Thanks!

@frankPairs
Copy link
Contributor Author

ok @djhi , during the next weeks I will update this PR.

Thanks!

@frankPairs
Copy link
Contributor Author

@djhi updated!

@djhi djhi merged commit 089dc3e into marmelab:next Mar 21, 2019
@djhi
Copy link
Contributor

djhi commented Mar 21, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frankPairs @fzaninotto @djhi