Fix custom actions cannot override basePath

[kopax]

Previously, it was impossible to write: <Show basePath="/foo" actions={<ShowActions basePath="/foo/bar" />} /> because we were not tolerating props on DefaultActions, making the API/props useless/broken.

[djhi]

Extract from react doc:

Clone and return a new React element using element as the starting point. The resulting element will have the original element’s props with the new props merged in shallowly

I'm quite sure this is not needed.

[kopax]

Indeed, it is.

cloneElement does keep props as you mentioned (doc), but createElement 2nd arguments will override any props set beforehand, making impossible to customize basePath, resource and so on.

It's easy to setup a test. I hit the bug and already verified, basePath can now be fully customized. Try to set any of the props you set in your second arguments of createElement and you'll reproduce it. I've applied the fix to the 4 crud routes.

It won't break, because, by default, none of the <DefaultAction /> set those props.

This was my use case, I have a custom route with path /projects/:projectId/services/:serviceId/newsletters/groups/:groupId/contacts/:id/show:

import React from 'react';
import WithPermissions from 'ra-core/lib/auth/WithPermissions';
import ShowActions from 'ra-ui-materialui/lib/detail/ShowActions';
import ProjectServiceNewsletterContactShowDefault from '../../resources/contacts/ProjectServiceNewsletterContactShow';

function ProjectServiceNewsletterContactShow({ roles, match, staticContext, ...rest }) {
  return (
    <WithPermissions
      render={({ permissions }) => (
        <ProjectServiceNewsletterContactShowDefault
          actions={<ShowActions basePath={"/newsletter/groups/contacts"} />}
          hasEdit={permissions.includes(roles.PROJECT_EDIT)}
          id={match.params.id}
          basePath={match.url}
          resource={"newsletter/groups/contacts"}
          {...rest}
        />
      )}
    />
  );
}

export default ProjectServiceNewsletterContactShow;

[kopax]

Thanks in advance for review

[djhi]

Ah I see. Fair point!

[djhi]

There are probably many places where this should be done too

[fzaninotto]

Thanks!