[RFR] Pluralize the confirmation message in BulkDeleteWithConfirmButton #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luwangel
changed the title
djhi
requested changes
Mar 26, 2019
| @@ -106,7 +106,7 @@ class BulkDeleteWithConfirmButton extends Component { | |||
| translateOptions={{ | |||
| smart_count: selectedIds.length, | |||
| name: inflection.humanize( | |||
| inflection.singularize(resource), | |||
| inflection.inflect(resource, selectedIds.length), | |||
There was a problem hiding this comment.
I think we should do even better. Many of users actually provide translations for their resources names. We should use them
There was a problem hiding this comment.
Good idea, but this should be done across all messages. Let's merge @Luwangel's PR and do that in another PR.
fzaninotto
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3040
Follows #2955
We use to singularize the confirm message in the
BulkDeleteWithConfirmButtoncomponent. But we often select more than one component. The solution is to use inflect to select wisely between pluralize or singularize.Todo
inflectinstead ofsingularizein theBulkDeleteWithConfirmButtoncomponent