-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Migrate ra-ui-materialui to TypeScript (Part 2: fields) #3091
Conversation
cab2191
to
c8f44bd
Compare
c8f44bd
to
6a5cff8
Compare
} | ||
|
||
// Props injected by react-admin | ||
export interface InjectedFieldProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be exported by ra-core
I'm going to revert the changes on all the Reference fields components. I believe they should leverage types declared but not yet exported from |
0d083ad
to
d4d6c07
Compare
@@ -12,7 +12,7 @@ describe('<SimpleShowLayout />', () => { | |||
<TextField source="bar" /> | |||
</SimpleShowLayout> | |||
); | |||
const inputs = wrapper.find('pure(TextField)'); | |||
const inputs = wrapper.find('EnhancedTextField'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By setting the displayName on the EnhancedTextField
, we can avoid testing implementation details (decoration by the pure
HOC) here
There are still some EDIT: Ok, my bad! |
Actually I added them back. Yes they are necessary for run time check for people not using TS |
needs rebase following changes on BooleanFields |
599053e
to
2aa80ea
Compare
2aa80ea
to
4c0776d
Compare
Wish me luck.
TODO
Identifier
instead of string everywhere anid
is usedwithTranslate
from Gildas' PR