[RFR] Migrate ra-ui-materialui to TypeScript (Part 2: fields) #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kmaschta
commented
Apr 3, 2019
Kmaschta
force-pushed
the
ra-mui-field-typescript
branch
3 times, most recently
from
cab2191
to
c8f44bd
Compare
djhi
force-pushed
the
ra-mui-field-typescript
branch
from
c8f44bd
to
6a5cff8
Compare
djhi
changed the title
djhi
changed the title
djhi
reviewed
Apr 17, 2019
| } | ||
|
|
||
| // Props injected by react-admin | ||
| export interface InjectedFieldProps { |
There was a problem hiding this comment.
I think this should be exported by ra-core
|
I'm going to revert the changes on all the Reference fields components. I believe they should leverage types declared but not yet exported from |
djhi
force-pushed
the
ra-mui-field-typescript
branch
from
0d083ad
to
d4d6c07
Compare
djhi
changed the title
djhi
reviewed
Apr 17, 2019
| @@ -12,7 +12,7 @@ describe('<SimpleShowLayout />', () => { | |||
| <TextField source="bar" /> | |||
| </SimpleShowLayout> | |||
| ); | |||
| const inputs = wrapper.find('pure(TextField)'); | |||
| const inputs = wrapper.find('EnhancedTextField'); | |||
There was a problem hiding this comment.
By setting the displayName on the EnhancedTextField, we can avoid testing implementation details (decoration by the pure HOC) here
|
There are still some EDIT: Ok, my bad! |
|
Actually I added them back. Yes they are necessary for run time check for people not using TS |
|
needs rebase following changes on BooleanFields |
fzaninotto
approved these changes
Apr 18, 2019
djhi
force-pushed
the
ra-mui-field-typescript
branch
from
599053e
to
2aa80ea
Compare
djhi
force-pushed
the
ra-mui-field-typescript
branch
from
2aa80ea
to
4c0776d
Compare
fzaninotto
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wish me luck.
TODO
Identifierinstead of string everywhere anidis usedwithTranslatefrom Gildas' PR