Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed AutocompleteInput popup to re-render after choice is selected #3190

Merged
merged 1 commit into from Jun 5, 2019
Merged

fixed AutocompleteInput popup to re-render after choice is selected #3190

merged 1 commit into from Jun 5, 2019

Conversation

FACOLOMBANI
Copy link
Contributor

Hi,

This is a PR to fix AutocompleteInput issue #2428. I added the prop focusInputOnSuggestionClick by default to false, and since the input loses focus on suggestion selection, i had to change the state when calling handleSuggestionSelected().

Best Regards.

@fzaninotto
Copy link
Member

You seem to use different prettier settings than us. Can you please avoid reformatting on save or use our prettier preset, to minimize the coding style changes?

@FACOLOMBANI
Copy link
Contributor Author

Of course, i apologize, just ran your prettier settings.

@fzaninotto
Copy link
Member

You patch doesn't work. I tested on the simple example, in a Comment detail, changing the related post doesn't work anymore.

@FACOLOMBANI
Copy link
Contributor Author

This is weird, i tested it locally on the reviews component using the customer filter and it worked fine, i'll check it again

@FACOLOMBANI
Copy link
Contributor Author

I added a new case in the handleChange function, can you please retest with this modification?

@djhi djhi added this to the 2.9.2 milestone May 22, 2019
@fzaninotto fzaninotto modified the milestones: 2.9.2, v2.9.3 May 28, 2019
@djhi djhi merged commit 23e875d into marmelab:master Jun 5, 2019
@djhi
Copy link
Contributor

djhi commented Jun 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants