Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Upgrade material-ui to v4 #3191

Merged
merged 32 commits into from May 9, 2019
Merged

[RFR] Upgrade material-ui to v4 #3191

merged 32 commits into from May 9, 2019

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented May 6, 2019

  • Upgrade dependencies in packages.json
  • Follow material-ui v4 upgrade documentation
  • Fix visual glitches in simple example
  • Fix visual glitches in demo example
  • Add upgrade instructions
  • Fix warnings
  • Fix tests

There are a few remaining warnings in the tests regarding useLayoutEffect doing nothing on the server on AutocompleteInput and AutocompleteArrayInput. I don't pay too much attention to it as these components will be replaced.

@fzaninotto fzaninotto added this to the 3.0.0 milestone May 6, 2019
@fzaninotto fzaninotto changed the title [BC Break] [WIP] Upgrade material-ui to v4 [BC Break] [RFR] Upgrade material-ui to v4 May 7, 2019
@fzaninotto
Copy link
Member Author

Switching to RFR

@fzaninotto fzaninotto mentioned this pull request May 7, 2019
40 tasks
@fzaninotto fzaninotto changed the title [BC Break] [RFR] Upgrade material-ui to v4 [RFR] Upgrade material-ui to v4 May 7, 2019
@fzaninotto
Copy link
Member Author

Back to WIP, I misunderstood makeStyles imports

@fzaninotto
Copy link
Member Author

Back to RFR

@djhi djhi merged commit fe5acd7 into next May 9, 2019
@djhi djhi deleted the mui4 branch May 9, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants