Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Move Actions out of the Card #3214

Merged
merged 10 commits into from
May 16, 2019
Merged

[RFR] Move Actions out of the Card #3214

merged 10 commits into from
May 16, 2019

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented May 11, 2019

  • Move ListActions out of the card
  • Make BulkActions stand out of the card
  • Move EditActions out of the card
  • Move ShowActions out of the card
  • Move CreateActions out of the card
  • [BC Break] Remove CardActions component (replaced by TopToolbar)
  • Update documentation and examples
  • Put white background behind actions on Mobile

ezgif com-video-to-gif (2)

Note that the change moves the content up in the list but down in the Edit view (when there are buttons), but the buttons and cards are aligned across views.

Page Before After
List localhost_8080_ (6) localhost_8080_ (1)
Edit localhost_8080_ (3) localhost_8080_
Show localhost_8080_ (4) localhost_8080_ (1)
Create localhost_8080_ (5) localhost_8080_ (2)

@djhi
Copy link
Contributor

djhi commented May 11, 2019

Looks great !

@fzaninotto fzaninotto added this to the 3.0.0 milestone May 14, 2019
@fzaninotto fzaninotto changed the title [WIP] Move Actions out of the Card [RFR] Move Actions out of the Card May 16, 2019
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👍

@djhi
Copy link
Contributor

djhi commented May 16, 2019

Would you mind posting screenshots of the mobile view ?

@fzaninotto
Copy link
Member Author

localhost_8080_ (3) localhost_8080_ (2) localhost_8080_ (4)

the last one has a width problem, which also exists in the current UI. It's due to the tabs not being responsive enough (that's a known material-ui bug).

@djhi djhi merged commit eb9c2f0 into next May 16, 2019
@djhi djhi deleted the ui-card branch May 16, 2019 10:04
@fzaninotto fzaninotto mentioned this pull request May 16, 2019
40 tasks
@serhiipalash
Copy link

Looks great @fzaninotto ! When will you plan to release v3?

@fzaninotto
Copy link
Member Author

see #3194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants