Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] [Rework] Datagrid rowclick toggle #3270

Merged
merged 7 commits into from
May 24, 2019

Conversation

fargito
Copy link
Contributor

@fargito fargito commented May 23, 2019

This is a rework of #3120

  • Allow rowClick="toggleSelection" option on DatagridRow
  • Add corresponding documentation
  • Add tests for all the rowClick options

Closes #3120

@djhi
Copy link
Contributor

djhi commented May 23, 2019

You're on 🔥 ! Thanks!

@djhi djhi modified the milestone: 2.9.2 May 23, 2019
@djhi
Copy link
Contributor

djhi commented May 23, 2019

However, this is technically a new feature and should target the next branch which will be the 3.0

@fargito
Copy link
Contributor Author

fargito commented May 23, 2019

Ok, I will rebase it from next

@fargito fargito changed the base branch from master to next May 23, 2019 14:31
@djhi djhi added this to the 3.0.0 milestone May 23, 2019
@fzaninotto fzaninotto merged commit 63537fd into marmelab:next May 24, 2019
@fzaninotto
Copy link
Member

Thanks!

@fargito fargito deleted the datagrid-rowclick-toggle branch May 27, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants