Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix filter condition to work with nested object paths #3274

Merged
merged 2 commits into from
Jun 5, 2019
Merged

fix filter condition to work with nested object paths #3274

merged 2 commits into from
Jun 5, 2019

Conversation

donatascn
Copy link

Fixing a bug from this issue: #2722

Kmaschta
Kmaschta suggested changes May 24, 2019
View reviewed changes
Copy link
Contributor

@Kmaschta Kmaschta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thank you!

Would you mind write a unit test for that change?
You'll find tests for that component in FilterForm.spec.js

@donatascn donatascn force-pushed the hotfix/disappearing-nested-filter-loc-change branch from 7b4dc30 to fdff494 Compare May 27, 2019 13:58
@donatascn
Copy link
Author

donatascn commented May 27, 2019 •
edited
Loading

I probably shouldn't have overwritten the commit history. Sorry!

@Kmaschta Kmaschta added this to the v2.9.3 milestone May 28, 2019
@djhi djhi merged commit b90d5d0 into marmelab:master Jun 5, 2019
@djhi
Copy link
Contributor

djhi commented Jun 5, 2019

Thanks!

@fzaninotto fzaninotto mentioned this pull request Jun 5, 2019
Closed
@scottlowe scottlowe mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@Kmaschta Kmaschta Kmaschta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donatascn @djhi @Kmaschta