[RFR] Fix design of icon loaders #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
May 24, 2019
| {isLoading && ( | ||
| <CircularProgress | ||
| className={classes.icon} | ||
| size={18} |
There was a problem hiding this comment.
Why set the size if you also set the width in css?
There was a problem hiding this comment.
You're right, the duplication is not useful. I've made changes.
fzaninotto
approved these changes
May 27, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<CircularProgress />icon in Login Form is too close to the text and too big. The solution is to add a margin and reduce its size.Todo
LoginFormSaveButtonScreenshots
Before
After