[RFR] Prettier #3304
Merged
[RFR] Prettier #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
djhi
commented
Jun 5, 2019
djhi
commented
- Upgrade Prettier
- Ensure Prettier Config is complete to avoid user overrides and applied to all files
- Apply prettier on the project
|
We should not upgrade prettier before we are about to release v3. It would make the backport of the |
Merged
As discussed I will make the same PR on |
|
Can you revert the line width change to minimize the patch? |
fzaninotto
reviewed
Jun 6, 2019
| ...rest | ||
| }) => { | ||
| export const ListView = withStyles(styles)(({ // component props | ||
| actions, aside, filter, filters, bulkActions, bulkActionButtons, pagination, children, className, classes, exporter, title, ...rest }) => { |
There was a problem hiding this comment.
Looks like the comments are doing this
fzaninotto
approved these changes
Jun 7, 2019
|
Thanks! Next step, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.