Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue where the URL validation is getting an error #3335

Merged
merged 1 commit into from Jun 13, 2019

Conversation

griiettner
Copy link
Contributor

The Issue: When trying to use TabbedForm inside a dialog modal, and click on Cancel button, I got the following error. TypeError: Cannot read property 'url' of null.

The Bug Reason: When the button cancel is clicked, the matchobject return null.

The Solution: Set the location.pathname instead when match returns null.

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the v2.9.3 milestone Jun 13, 2019
@djhi djhi merged commit 187fe44 into marmelab:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants