Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix DashboardMenuItem className prop #3357

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Kmaschta
Copy link
Contributor

@Kmaschta Kmaschta commented Jun 24, 2019

Problem

When (re)using the component <DashboardMenuItem>, if pass it a className prop it is supressed by the component and not passed to its children MenuItem.

Solution

  1. Pass the className prop to its children
  2. or, let this one in the default props passed in the children

I choose the second one, because this prop isn't used anyway.

@Kmaschta Kmaschta added this to the 2.9.4 milestone Jun 24, 2019
@fzaninotto fzaninotto merged commit b2246d9 into master Jun 25, 2019
@fzaninotto fzaninotto deleted the fix-dashboard-menu-item-classname branch June 25, 2019 18:04
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants