Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix Dead Link to Bulk Action Buttons in Docs #3361

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

bmuthoga
Copy link
Contributor

@bmuthoga bmuthoga commented Jun 25, 2019

Fixes #3355

What Does This PR Do?

This PR fixes the dead link to the Bulk Action Buttons implementation example in https://marmelab.com/react-admin/Actions.html#list-bulk-actions


"You can find a complete example of a custom Bulk Action button in the List documentation, 
in the Bulk Action Buttons section." <--- Here

Description Of Task To Be Completed

  • Clicking on the link should navigate the user to the Bulk Action Buttons implementation example in List markdown instead of displaying a Not Found page

Any Background Context You Want To Provide?

  • N/A

How can this be manually tested?

  • Navigate to here
  • Click on Bulk Action Buttons
  • The page should navigate to here instead of displaying a Not Found page

References #3355

@bmuthoga bmuthoga mentioned this pull request Jun 25, 2019
@djhi
Copy link
Contributor

djhi commented Jun 25, 2019

Thanks!

@djhi djhi added this to the 2.9.4 milestone Jun 25, 2019
@djhi djhi merged commit 847e779 into marmelab:master Jun 25, 2019
@WiXSL
Copy link
Contributor

WiXSL commented Jun 25, 2019

I just find out that every link in https://marmelab.com/react-admin/List.html pointing to MUI website is dead other than this.

@bmuthoga
Copy link
Contributor Author

bmuthoga commented Jun 25, 2019

I can work on that too in a few hours time since it's related. Would you prefer it in a new branch or this same branch? Scratch that, I've seen there's one already 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Dead Link.
3 participants