[RFR] Support API empty response on DELETE and DELETE_MANY actions #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kmaschta
changed the title
Kmaschta
changed the title
fzaninotto
requested changes
Jul 22, 2019
docs/DataProviders.md
Outdated
| @@ -467,8 +467,8 @@ Request Type | Response format | |||
| `CREATE` | `{ data: {Record} }` | |||
| `UPDATE` | `{ data: {Record} }` | |||
| `UPDATE_MANY` | `{ data: {mixed[]} }` The ids which have been updated | |||
| `DELETE` | `{ data: {Record} }` | |||
| `DELETE_MANY` | `{ data: {mixed[]} }` The ids which have been deleted | |||
| `DELETE` | `{ data: {Record} }` The resource that had been deleted or nothing | |||
There was a problem hiding this comment.
Suggested change
| `DELETE` | `{ data: {Record} }` The resource that had been deleted or nothing | |
| `DELETE` | `{ data: {Record} }` The record that has been deleted |
There was a problem hiding this comment.
I would precise, to the data provider maintainers that this data isn't required.
docs/DataProviders.md
Outdated
| `DELETE` | `{ data: {Record} }` | ||
| `DELETE_MANY` | `{ data: {mixed[]} }` The ids which have been deleted | ||
| `DELETE` | `{ data: {Record} }` The resource that had been deleted or nothing | ||
| `DELETE_MANY` | `{ data: {mixed[]} }` The ids which have been deleted or an empty array |
There was a problem hiding this comment.
Suggested change
| `DELETE_MANY` | `{ data: {mixed[]} }` The ids which have been deleted or an empty array | |
| `DELETE_MANY` | `{ data: {mixed[]} }` The ids of the deleted records |
There was a problem hiding this comment.
Idem, I would precise, to the data provider maintainers that this data isn't required.
|
Any update ? |
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Kmaschta
force-pushed
the
avoid-error-messages-when-empty-response
branch
from
95d3ccf
to
f67c27d
Compare
Kmaschta
force-pushed
the
avoid-error-messages-when-empty-response
branch
from
f67c27d
to
29d1670
Compare
|
Reviews applied and rebased |
djhi
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I checked for both
DELETEandDELETE_MANYactions.DELETEdoesn't require to have an identifier ({ data: { id: 'id' } }) but needs to have a data key, which should be returned by the data providerDELETE_MANYshould return a data as a array, but do not require to have something in that array. If the API doesn't return a response, the data provider will return an empty arrayNote : It is possible for the data provider to return the ids or resources sent with the request thanks to the
paramsargument, but since react admin does nothing with this data, I preferred to remove not require it.