Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix hide filter button isn't aligned with field #3449

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

fzaninotto
Copy link
Member

Closes #3432

Before:

image

After:

image

@fzaninotto fzaninotto added this to the 3.0.0 milestone Jul 23, 2019
const FilterFormInput = ({ filterElement, handleHide, classes, resource }) => {
const useStyles = makeStyles(theme => ({
body: { display: 'flex', alignItems: 'flex-end' },
spacer: { width: '1em' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use theme.spacing here too so that spaces are consistent

@djhi djhi merged commit 108d6be into next Jul 24, 2019
@djhi djhi deleted the fix-hide-filter-alignment branch July 24, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants