Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BC Break] Migrate from redux-form to react-final-form #3455

Merged
merged 27 commits into from
Aug 1, 2019
Merged

[BC Break] Migrate from redux-form to react-final-form #3455

merged 27 commits into from
Aug 1, 2019

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jul 24, 2019

No description provided.

@djhi djhi marked this pull request as ready for review July 29, 2019 15:12
fzaninotto
fzaninotto requested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review so far

examples/demo/src/orders/OrderList.js Outdated Show resolved Hide resolved
examples/demo/src/reviews/RejectButton.js Outdated Show resolved Hide resolved
examples/demo/src/reviews/RejectButton.js Outdated Show resolved Hide resolved
examples/demo/src/reviews/reviewSaga.js Show resolved Hide resolved
examples/simple/src/posts/PostCreate.js Outdated Show resolved Hide resolved
examples/simple/src/posts/PostCreate.js Outdated Show resolved Hide resolved
examples/simple/src/posts/PostEdit.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
packages/ra-core/package.json Outdated Show resolved Hide resolved
fzaninotto
fzaninotto requested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

examples/demo/src/reviews/RejectButton.js Outdated Show resolved Hide resolved
examples/simple/src/posts/PostCreate.js Outdated Show resolved Hide resolved
packages/ra-core/src/controller/useEditController.spec.tsx Show resolved Hide resolved
packages/ra-core/src/controller/useEditController.spec.tsx Outdated Show resolved Hide resolved
packages/ra-core/src/controller/useEditController.ts Show resolved Hide resolved
packages/ra-ui-materialui/src/auth/LoginForm.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/form/FormTab.js Show resolved Hide resolved
packages/ra-ui-materialui/src/form/SimpleForm.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/form/SimpleForm.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/form/SimpleForm.js Outdated Show resolved Hide resolved
fzaninotto
fzaninotto requested changes Jul 30, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review!

I wonder if we're not missing one part: the rewrite of all Input fields to remove their addField HOC. What do you think?

packages/ra-ui-materialui/src/form/TabbedForm.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/form/TabbedForm.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/form/TabbedForm.js Show resolved Hide resolved
packages/ra-ui-materialui/src/form/TabbedForm.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/ArrayInput.spec.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/list/FilterForm.js Show resolved Hide resolved
packages/ra-ui-materialui/src/list/FilterForm.js Outdated Show resolved Hide resolved
@djhi
Copy link
Contributor Author

djhi commented Jul 30, 2019

I wonder if we're not missing one part: the rewrite of all Input fields to remove their addField HOC. What do you think?

react-final-form still provide a Field component so we still need the HOC, right ?

djhi added 23 commits July 31, 2019 09:54
@djhi
Migrate from redux-form to react-final-form
306aef5
@djhi
Fix filter form
2ec0fea
@djhi
Fix unit tests and form initialization
a0b32ff
@djhi
Fix ArrayInput
0d2059d
@djhi
Fix custom forms
cced933
@djhi
Fix list filters form
39845eb
@djhi
Remove deprecated tests
6a2fa77
@djhi
Review
70078ce
@djhi
Correct version of react-redux typings
e29e58b
@djhi
Fix composeValidators
53e9fc8
@djhi
Fix TabbedForm submit
feb26da
@djhi
Revert usage of composeValidators in simple example
eea3f6e
@djhi
Correctly use side effects
dd38c42
@djhi
More readable re-initialization of form from record
dcc9948
@djhi
review readability
2aec153
@djhi
Missing yarn lock
5530f21
@djhi
useFormState
6231f2d
@djhi
Update redirection saga to work like the hook
e0a8191
@djhi
Add composeValidators tests
72f540f
@djhi
Restore TestContext tests
748e62e
@djhi
Rename component in LoginForm
1eca7cc
@djhi
Restructure form components code
20ea666
@djhi
Fix simple example
d922c42
fzaninotto
fzaninotto reviewed Jul 31, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close! This PR still lacks documentation and upgrade updates.

packages/ra-core/src/form/FormDataConsumer.tsx Show resolved Hide resolved
packages/ra-core/src/form/validate.spec.ts Outdated Show resolved Hide resolved
packages/ra-core/src/form/validate.spec.ts Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/auth/LoginForm.tsx Show resolved Hide resolved
packages/ra-ui-materialui/src/list/FilterForm.js Show resolved Hide resolved
@fzaninotto fzaninotto changed the title Migrate from redux-form to react-final-form [BC Break] Migrate from redux-form to react-final-form Aug 1, 2019
@fzaninotto fzaninotto merged commit 0dc0994 into next Aug 1, 2019
@fzaninotto fzaninotto deleted the react-final-form branch August 1, 2019 06:56
@fzaninotto fzaninotto added this to the 3.0.0 milestone Aug 1, 2019
@fzaninotto fzaninotto mentioned this pull request Aug 1, 2019
Closed
40 tasks
@fzaninotto fzaninotto mentioned this pull request Aug 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djhi @fzaninotto