[RFR] Upgrade types #3463
Merged
[RFR] Upgrade types #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Jul 26, 2019
| @@ -10,7 +10,7 @@ export interface DefaultValueProps extends InputProps { | |||
| initializeForm: typeof initializeFormAction; | |||
| } | |||
|
|
|||
| export class DefaultValueView extends Component<DefaultValueProps> { | |||
| export class DefaultValueView extends Component<any> { | |||
There was a problem hiding this comment.
because the connect call at the end of the file triggers this cryptic TypeScript error:
Argument of type 'typeof DefaultValueView' is not assignable to parameter of type 'ComponentType<never>'.
Type 'typeof DefaultValueView' is not assignable to type 'ComponentClass<never, any>'.
Types of property 'propTypes' are incompatible.
Type '{ decoratedComponent: Requireable<ReactElementLike | ((...args: any[]) => any)>; defaultValue: Requireable<any>; initializeForm: Validator<(...args: any[]) => any>; input: Requireable<object>; source: Requireable<...>; validate: Requireable<...>; }' is not assignable to type 'never'.ts(2345)
And I don't know how to silence it.
djhi
approved these changes
Jul 26, 2019
Kmaschta
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/react-reduxyarn upgradeto fix errors due to duplicated type dependenciesSupersedes #3065
May fix #2978