Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix Review accept / reject in demo #3473

Merged
merged 4 commits into from
Jul 31, 2019
Merged

[RFR] Fix Review accept / reject in demo #3473

merged 4 commits into from
Jul 31, 2019

Commits on Jul 30, 2019

  1. Fix AcceptButton 

    Object side effects no longer work with useMutation
    @fzaninotto
    fzaninotto committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    29a6a1e View commit details
    Browse the repository at this point in the history

  2. Fix race condition in useMutation 

    because the caching strategy of useMutation was too drastic, it missed changes in isOptimistic and produced callbacks that were not informed that the optimistic mode is disabled
    @fzaninotto
    fzaninotto committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    dc143f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. add argument control to useDataProvider to avoid unseen mistakes

    @fzaninotto
    fzaninotto committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    73b4fa1 View commit details
    Browse the repository at this point in the history

  2. Fix bulk accept and delete in demo

    @fzaninotto
    fzaninotto committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0d8a864 View commit details
    Browse the repository at this point in the history