Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] check if authProvider is defined #3505

Merged
merged 5 commits into from
Aug 12, 2019
Merged

[RFR] check if authProvider is defined #3505

merged 5 commits into from
Aug 12, 2019

Conversation

Kunnu01
Copy link
Contributor

@Kunnu01 Kunnu01 commented Aug 10, 2019

fixes: #3239

djhi
djhi reviewed Aug 10, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

packages/ra-core/src/CoreAdminRouter.tsx Outdated Show resolved Hide resolved
djhi
djhi requested changes Aug 10, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this case though?

@djhi djhi requested a review from Kmaschta August 12, 2019 10:31
@Kmaschta Kmaschta added this to the 2.9.6 milestone Aug 12, 2019
@Kmaschta Kmaschta merged commit e5a8c85 into marmelab:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@Kmaschta Kmaschta Kmaschta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.6
Development

Successfully merging this pull request may close these issues.

Infinite loading view when declaring resource at runtime with no authProvider
3 participants
@Kunnu01 @djhi @Kmaschta