[RFR] createAdminStore - set initialState on logout

[natrim]

to prevent undefined behaviour

fixes having undefined state instead of new state

ie. if you have some inital data from localStorage, then you dont wanna forget them on logout

and if initialState is function, call it to get the state

[Kmaschta]

Since it's a new feature, you should aim to the next branch instead of master.
We're preparing the V3, which is under heavy development on that branch.

Also, it would be better to prepare an enhancement issue to explain what are you suggesting, and why do you think it's a good idea.

[natrim]

well it's not really fully new feature (i just though function would be nice to have in initial state)
but the bug is in state becoming undefined after user logout

consider situation like this, user goes to the app, the app initializes with initialState that contains "important" information (ie. theme, rows per page, or some "stuff")

but then the user logouts and suddenly the app state is undefined, it should really reset to initialState and not undefined

[Kmaschta]

I agree with you! That being said, only bug fixes are merged on master.

By "new feature" I meant that this is a totally new behavior of React Aadmin, and this change might even break production apps in some way.

Moreover, this PR introduces a new feature in the public API: thie initialState prop as function.
This PR should aims at the next branch.

Finally, since the initialState change, mind you update the documentation about the <Admin> component please?

[natrim]

ok,
changed pull target to next,
added notice about the function possibility to doc

[Kmaschta]

I would add a word on the UPGRADE.md to in order to warn about the store reset, but I'll let the core maintainers decide about that.

[fzaninotto]

Thanks!