Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Remove BulkActions in V3 #3517

Merged
merged 6 commits into from
Aug 20, 2019
Merged

[RFR] Remove BulkActions in V3 #3517

merged 6 commits into from
Aug 20, 2019

Conversation

Kunnu01
Copy link
Contributor

@Kunnu01 Kunnu01 commented Aug 13, 2019 •
edited
Loading

  • Remove BulkActions

@Kunnu01 Kunnu01 changed the title Remove bulk actions in V3 Remove BulkActions in V3 Aug 13, 2019
@Kunnu01 Kunnu01 changed the title Remove BulkActions in V3 [RFR] Remove BulkActions in V3 Aug 13, 2019
@Kmaschta Kmaschta mentioned this pull request Aug 13, 2019
Closed
Kmaschta
Kmaschta suggested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@Kmaschta Kmaschta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind you add a word in UPGRADE.md about this component?
There is a dedicated section about removed deprecated components that were removed

Kmaschta
Kmaschta suggested changes Aug 13, 2019
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
djhi
djhi requested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this component also implies updating the List component which used it

@Kunnu01
Copy link
Contributor Author

Kunnu01 commented Aug 13, 2019 •
edited
Loading

Removing this component also implies updating the List component which used it

List uses a prop name bulkActions. Are you talking about that?
If yes, ListToolbar also uses it. Should I remove it from both the files?

@djhi
Copy link
Contributor

djhi commented Aug 13, 2019

List uses a prop name bulkActions. Are you talking about that?

Yes

If yes, ListToolbar also uses it. Should I remove it from both the files?

Yes :)

djhi
djhi requested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 👍

packages/ra-ui-materialui/src/list/ListToolbar.js
@@ -52,7 +51,6 @@ const ListToolbar = ({
React.cloneElement(actions, {
...rest,
className: styles.actions,
bulkActions,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have to update the default ListActions too

djhi
djhi approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I'll wait for @fzaninotto review though, just to be sure :)

@djhi djhi added this to the 3.0.0 milestone Aug 13, 2019
@fzaninotto
Copy link
Member

Neat! I think the Upgrade guide should be a bit more explicit, by showing a code snippet with a before/after diff.

@Kunnu01
Copy link
Contributor Author

Kunnu01 commented Aug 18, 2019

Okay, I'll update it. Do you want it in a specific format or should I just simply add code snippets saying before and after?

@fzaninotto
Copy link
Member

Check the rest of the UPGRADE file: we use snippets with the diff syntax. Try to do the same.

@Kunnu01
Copy link
Contributor Author

Kunnu01 commented Aug 20, 2019

Done. Please review. :)

djhi
djhi approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@fzaninotto fzaninotto merged commit d5fb353 into marmelab:next Aug 20, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto changed the title [RFR] Remove BulkActions in V3 [RFR] [BC Break] Remove BulkActions in V3 Aug 20, 2019
@fzaninotto fzaninotto changed the title [RFR] [BC Break] Remove BulkActions in V3 [RFR] Remove BulkActions in V3 Aug 20, 2019
@fzaninotto fzaninotto mentioned this pull request Aug 20, 2019
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kmaschta Kmaschta Kmaschta requested changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kunnu01 @djhi @fzaninotto @Kmaschta