[RFR] Migrate RadioButtonGroupInput to use useInput #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Aug 19, 2019
| expect(input2.type).toBe('radio'); | ||
| expect(input2.name).toBe('foo'); | ||
| expect(input2.name).toBe('type'); | ||
| expect(input2.checked).toBeFalsy(); | ||
| }); | ||
|
|
||
| it('should use the input parameter value as the initial input value', () => { |
There was a problem hiding this comment.
you've completely changed the tes implementation, so the test title no longer corresponds to the implementation.
There was a problem hiding this comment.
I don't really get that comment. initialValues provides the initial input value and we check that is indeed applied to the underlying input
There was a problem hiding this comment.
we no longer use the 'input parameter value', as the test description says
packages/ra-ui-materialui/src/input/RadioButtonGroupInput.spec.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
djhi
force-pushed
the
radiobuttongroupinput-useinput
branch
from
bcef715
to
0f7ba10
Compare
fzaninotto
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.