[RFR] Convert NodeForm component to hooks #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Aug 26, 2019
|
|
||
| handleClick = event => { | ||
| const handleClick = event => { |
There was a problem hiding this comment.
Please wrap the event handlers with useCallback
djhi
reviewed
Aug 26, 2019
|
|
||
| handleSubmit = () => { | ||
| const handleSubmit = () => { |
There was a problem hiding this comment.
Any reason to not wrap this one inside a useCallback too ?
There was a problem hiding this comment.
Good question, it looked a bit non-trivial than the other two and I wasn't sure if it would subtly break anything if I wrapped it the wrong way. I'll give it a try.
djhi
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert NodeForm component to hooks