[RFR] Upgrade React-router #3744
Conversation
| @@ -40,42 +40,38 @@ const useLogout = (): Logout => { | |||
|
|
|||
| const store = useStore(); | |||
| const dispatch = useDispatch(); | |||
| const history = useHistory(); | |||
|
|
|||
| const logout = useCallback( | |||
| (params = {}, redirectTo = defaultAuthParams.loginUrl) => | |||
| authProvider.logout(params).then(redirectToFromProvider => { | |||
| dispatch(clearState()); | |||
| const currentLocation = store.getState().router.location; | |||
There was a problem hiding this comment.
Can't you get rid of this one redux usage?
| return redirectToFromProvider; | ||
| }), | ||
| [authProvider, store, dispatch] | ||
| [authProvider, store, history, dispatch] | ||
| ); | ||
|
|
||
| const logoutWithoutProvider = useCallback( | ||
| _ => { | ||
| const currentLocation = store.getState().router.location; |
| <Provider store={createStore(() => ({}))}> | ||
| <Dummy /> | ||
| </Provider> | ||
| <MemoryRouter> |
There was a problem hiding this comment.
you can pretty much use the TestContext here
There was a problem hiding this comment.
I cleanup those tests and rewrote them using rtl. One of them was useless
|
also, do we still use |
|
And there is the FIXME in the CloneButton, can we get rid of it? |
Only place left is in the saving reducer.
We might remove the comment, however, I'm not sure we should pass the record in the state. Having it in the URL is a good thing imo: explicit, allow to refresh the page, copy/paste the url, etc. |
I think we can get rid of this one, as the As it's a BC break, we'd better do it now.
I agree. Can you check that using the |
No description provided.