Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix SelectInput Warnings #3750

Merged
merged 1 commit into from
Sep 30, 2019
Merged

[RFR] Fix SelectInput Warnings #3750

merged 1 commit into from
Sep 30, 2019

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Sep 30, 2019

When using a SelectInput inside a ReferenceInput, choices prop should not be required as this is the job of the ReferenceInput to provide them, not the user

@djhi djhi added this to the 3.0.0 milestone Sep 30, 2019
@fzaninotto fzaninotto merged commit d8a7b59 into next Sep 30, 2019
@fzaninotto fzaninotto deleted the fix-select-input-warnings branch September 30, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djhi @fzaninotto