Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak ResettableTextField adornment style #3891

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Tweak ResettableTextField adornment style #3891

merged 2 commits into from
Oct 28, 2019

Conversation

tdeo
Copy link
Contributor

@tdeo tdeo commented Oct 28, 2019

In general, the clear icon hover background wasn't centered with
the icon itself. Also, on a SelectInput, the clear icon was
overlapping with the select's arrow:

Before:
Screenshot 2019-10-28 at 16 20 06

After:
Screenshot 2019-10-28 at 16 20 15

tdeo and others added 2 commits October 28, 2019 16:25
@tdeo
Tweak ResettableTextField adornment style
ea858fb 
In general, the clear icon hover background wasn't centered with
the icon itself. Also, on a SelectInput, the clear icon was
overlapping with the select's arrow:

Before:
@tdeo
Prettier
32a1711
djhi
djhi approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.0.0 milestone Oct 28, 2019
@djhi djhi merged commit b9973de into marmelab:next Oct 28, 2019
@tdeo tdeo deleted the patch-4 branch October 29, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdeo @djhi