Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resettable SelectInput with value doesn't show options on click #3932

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix resettable SelectInput with value doesn't show options on click #3932

merged 1 commit into from
Nov 7, 2019

Conversation

tdeo
Copy link
Contributor

@tdeo tdeo commented Nov 5, 2019

Today, when a SelectInput is resettable, the end adorments prevents clicking on the select arrow on the right to open the dropdown (see https://codesandbox.io/s/intelligent-almeida-24cm2).

I also removed the padding on the right in order to avoid a zone where clicking isn't captured

@fzaninotto fzaninotto changed the title Tweak SelectInput's endAdornment Fix resettable SelectInput with value doesn't show options on click Nov 7, 2019
@fzaninotto fzaninotto added this to the 3.0.0 milestone Nov 7, 2019
@fzaninotto fzaninotto merged commit 7275d7e into marmelab:next Nov 7, 2019
@fzaninotto
Copy link
Member

Thanks!

@tdeo tdeo deleted the resettableSelectInput branch November 8, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants