Add name option to makeStyles #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanudeSandstorm
changed the title
fzaninotto
reviewed
Nov 7, 2019
DanudeSandstorm
force-pushed
the
makestyles-options
branch
2 times, most recently
from
8496ef7
to
90b97bc
Compare
DanudeSandstorm
changed the title
fzaninotto
requested changes
Nov 8, 2019
There was a problem hiding this comment.
I think we should prefix all names with 'Ra' - just like material-ui prefixes all their names with 'Mui'. That's because the names go to a pool shared between libraries, and there is a good chance that List and other generic names are already present.
I'm sorry to realize that just now, after telling you to go ahead with the initial design, but I just understood the risk by reading your PR.
Would you mind updating all the names you've added to add the 'Ra' prefix?
|
@DanudeSandstorm can you rebase? |
DanudeSandstorm
force-pushed
the
makestyles-options
branch
from
a5b96f8
to
4979a0b
Compare
|
I rebased onto next |
|
Thank you. |
|
@fzaninotto , is this PR ready to be merged? |
fzaninotto
approved these changes
Nov 26, 2019
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've begun adding the name of the component in the ra-ui-materialui components that use
makeStylesas mentioned in #3701 .Please let me know whether this is what is expected and I can perform this addition on the remaining components.
Note: There's a difference in prettier/linting specification between
.tsxand.jsfiles, which results in differences in the makeStyles formatting.