Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong syntax in custom menu example #4023

Merged
merged 1 commit into from Nov 22, 2019
Merged

Fix wrong syntax in custom menu example #4023

merged 1 commit into from Nov 22, 2019

Conversation

fzaninotto
Copy link
Member

closes #4020

@fzaninotto fzaninotto added the RFR Ready For Review label Nov 22, 2019
@fzaninotto fzaninotto added this to the 3.0.1 milestone Nov 22, 2019
@djhi djhi merged commit 83f2b4e into master Nov 22, 2019
@djhi djhi deleted the fix-custom-menu-example branch November 22, 2019 09:22
prasanna214 added a commit to prasanna214/react-admin that referenced this pull request Apr 4, 2020
@prasanna214
Make useInput hook return child's input.value when parent's enhanced …
fe2cdb1 
…input.value is undefined.

Closes marmelab#4023[marmelab#4203].

Issue was caused by useField hook of final-form returning defaultValue of field as undefined (when it is not yet available in  state) while enhancing the parent input.

useInput hook of react-admin is considering same enhanced input with value undefined while rendering the children.
prasanna214 added a commit to prasanna214/react-admin that referenced this pull request Apr 4, 2020
@prasanna214
Make useInput hook return child's input.value when parent's enhanced …
827db44 
…input.value is undefined.

Closes marmelab#4023[marmelab#4203].

Issue was caused by useField hook of final-form returning defaultValue of field as undefined (when it is not yet available in  state) while enhancing the parent input.

useInput hook of react-admin is considering same enhanced input with value undefined while rendering the children.
@prasanna214 prasanna214 mentioned this pull request Apr 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

Custom Menu Example (on the docs) wont work in v 3.0.0
2 participants
@fzaninotto @djhi