[RFR] Add allowDuplicates for AutocompleteArrayInput #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Nov 22, 2019
There was a problem hiding this comment.
Can you please update the related documentation (in docs/Inputs.md)?
Also, you say this follows #2912, but I understand it replaces it, am I right?
| @@ -169,15 +174,15 @@ export const getSuggestionsFactory = ({ | |||
| // ignore the filter to show more choices | |||
| suggestions = removeAlreadySelectedSuggestions( | |||
| choices, | |||
| selectedItem, | |||
| allowDuplicates ? null : selectedItem, | |||
There was a problem hiding this comment.
if allowDuplicates is true, removeAlreadySelectedSuggestions() returns the input unchanged, so I'd prefer that you test it it's true on lone 175 and avoid calling removeAlreadySelectedSuggestions altogether in that case.
alanpoulain
force-pushed
the
autocomplete-array-input-allow-duplicates
branch
from
d5da818
to
f41214a
Compare
|
The related documentation has been updated. I've also added the The code has been updated to follow your recommendation too. And yes it replaces #2912. |
fzaninotto
approved these changes
Nov 24, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2912 and fixes #2311.
In React-admin 3, it's not possible to have duplicated values anymore for the
AutocompleteArrayInput. However it could be useful to allow this behavior in some cases.