Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for isRowSelectable prop. #4064

Merged
merged 5 commits into from Nov 28, 2019
Merged

Added documentation for isRowSelectable prop. #4064

merged 5 commits into from Nov 28, 2019

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 27, 2019

No description provided.

fzaninotto
fzaninotto requested changes Nov 28, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading your documentation, I realize that the prop name isn't well chosen. isRowSelectable or showSelectionControl would have been better. Would you mind taking advantage of this PR to rename the prop in the code?

docs/List.md Outdated Show resolved Hide resolved
@WiXSL @fzaninotto
Update docs/List.md
1ec91c8 
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
fzaninotto
fzaninotto reviewed Nov 28, 2019
View reviewed changes
docs/List.md Outdated Show resolved Hide resolved
WiXSL and others added 3 commits November 28, 2019 10:30
@WiXSL @fzaninotto
Update docs/List.md
10f710d 
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Renamed Datagrid's canSelectRow prop to isRowSelectable
21aed06
Merge remote-tracking branch 'origin/canrowselect-docs-next' into can…
5b416dd 
…rowselect-docs-next

# Conflicts:
#	docs/List.md
@WiXSL
Copy link
Contributor Author

WiXSL commented Nov 28, 2019 •
edited

Done!
I change it to isRowSelectable.
I realize I used canRowSelect in the docs, but the name was canSelectRow.
Is more usable with isRowSelectable.

@fzaninotto fzaninotto added this to the 3.1.0 milestone Nov 28, 2019
@fzaninotto fzaninotto merged commit 2e91924 into marmelab:next Nov 28, 2019
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL deleted the canrowselect-docs-next branch November 28, 2019 16:18
@WiXSL WiXSL changed the title Added documentation for canRowSelect prop. Added documentation for isRowSelectable prop. Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WiXSL @fzaninotto