Add invite to create the first record when the list is empty #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Dec 10, 2019
m4theushw
force-pushed
the
empty-page
branch
from
6957ccd
to
3d102f8
Compare
|
PR rebased |
|
sorry, a recent PR merge modified the List doc and requires a new rebase for this PR |
m4theushw
force-pushed
the
empty-page
branch
from
ddf4037
to
fd1176c
Compare
|
Ready! |
fzaninotto
requested changes
Dec 11, 2019
| @@ -40,6 +40,8 @@ module.exports = { | |||
| loading: 'Chargement', | |||
| not_found: 'Page manquante', | |||
| show: '%{name} #%{id}', | |||
| empty: 'Pas encore de %{name}.', | |||
| invite: 'Voulez-vous en créer un ?', | |||
There was a problem hiding this comment.
This will cause bad wording when the resource name is feminine (ex: promotion). But I don't see an easy way to fix that, so we'll go with that translation.
There was a problem hiding this comment.
We could leave to user to override the empty text, by looking for a resources.foobar.empty key. If there's no such key we use the default one ra.page.empty.
The invite key could also be customizable, like resources.foobar.invite.
There was a problem hiding this comment.
Great idea. Would you mind adding that feature to your PR?
There was a problem hiding this comment.
I'll work on it
m4theushw
force-pushed
the
empty-page
branch
2 times, most recently
from
aeb26d7
to
aab6cb8
Compare
ThieryMichel
approved these changes
Jan 3, 2020
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2639