Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification component autoHideDuration prop not being used. #4311

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Notification component autoHideDuration prop not being used. #4311

merged 2 commits into from
Jan 17, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jan 17, 2020 •
edited
Loading

Fixes #4298

djhi
djhi requested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/ra-core/src/sideEffect/useNotify.ts Outdated Show resolved Hide resolved
@WiXSL @djhi
Update packages/ra-core/src/sideEffect/useNotify.ts
c4545df 
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@WiXSL WiXSL requested a review from djhi January 17, 2020 13:41
djhi
djhi approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@djhi djhi added this to the 3.1.3 milestone Jan 17, 2020
@djhi
Copy link
Contributor

djhi commented Jan 17, 2020

I won't merge it now though because @fzaninotto may want to move it on next

fzaninotto
fzaninotto approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the doc said it's possible, it's actually a bug fix... So let's merge it to master.

@fzaninotto fzaninotto merged commit e6b5830 into marmelab:master Jan 17, 2020
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL deleted the patch-notification-auto-hide-duration branch January 17, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

React Admin Notification third param as seconds has no effect.
3 participants
@WiXSL @djhi @fzaninotto