Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the default app weight by removing the image background on the Login screen #4342

Merged
merged 4 commits into from
Jan 31, 2020

Conversation

ThieryMichel
Copy link

@ThieryMichel ThieryMichel commented Jan 22, 2020

Replace default unsplash image for Login component by a simple gradient.

Demo login is unchanged.

Preview:

image

@ThieryMichel ThieryMichel added the RFR Ready For Review label Jan 22, 2020
@djhi djhi added this to the 3.1.4 milestone Jan 22, 2020
@fzaninotto
Copy link
Member

If I'm not mistaken, that's a breaking change: people having defined a custom image for the background will lose it. Can you make the change backwards compatible?

@alanpoulain
Copy link
Contributor

It seems to me it's even worse since the default prop has been removed from ra-ui-materialui. People not having a custom backgroundImage prop will have a blank page.

Also only the demo has been changed, why not using this for the framework?

Nice change btw 🙂

@ThieryMichel
Copy link
Author

If I'm not mistaken, that's a breaking change: people having defined a custom image for the background will lose it. Can you make the change backwards compatible?

I just removed the default value for the background image. Only people that specified no backround image will have a white background. Which can be considered a breaking change. I can split the PR.

  • One to change the demo login page (no BC)
  • One to remove the default value for Login default backgroundImage (BC)

@ThieryMichel
Copy link
Author

Well totally changed the pr to only replace the unspalsh default image with a gradient in the Login component.

@fzaninotto
Copy link
Member

this needs to be done on the next branch as it's not a bug fix

@fzaninotto fzaninotto changed the title Remove unsplash background Reduce the default app weight by removing the image background on the Login screen Jan 23, 2020
@@ -44,6 +44,8 @@ const useStyles = makeStyles(
justifyContent: 'flex-start',
backgroundRepeat: 'no-repeat',
backgroundSize: 'cover',
backgroundImage:
Copy link
Member

@fzaninotto fzaninotto Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested alternative: 'radial-gradient(circle at 50% 14em, #313264 0%, #00023b 60%, #00023b 100%)'

@ThieryMichel ThieryMichel changed the base branch from master to next January 24, 2020 12:15
@fzaninotto
Copy link
Member

fzaninotto commented Jan 27, 2020

You should also update the Theming.md documentation:

image

Using the random URL from unsplash would help people find the same look and feel as before the update.

@fzaninotto fzaninotto modified the milestones: 3.1.4, 3.2.0 Jan 28, 2020
@fzaninotto fzaninotto merged commit a3a8175 into next Jan 31, 2020
@fzaninotto fzaninotto deleted the remove_unsplash_background branch January 31, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants