Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for use of Fields inside SimpleFormIterator #4477

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Add documentation for use of Fields inside SimpleFormIterator #4477

merged 2 commits into from
Mar 5, 2020

Conversation

JulienMattiussi
Copy link
Contributor

Closes #2500

Screenshot

image

@JulienMattiussi JulienMattiussi added the WIP Work In Progress label Mar 5, 2020
@JulienMattiussi JulienMattiussi changed the base branch from master to next March 5, 2020 14:37
@JulienMattiussi JulienMattiussi added the RFR Ready For Review label Mar 5, 2020
@fzaninotto fzaninotto merged commit a16e3d1 into next Mar 5, 2020
@fzaninotto fzaninotto deleted the doc-simple-form-iterator-fiels branch March 5, 2020 14:50
@fzaninotto fzaninotto added this to the 3.3.0 milestone Mar 5, 2020
@fzaninotto fzaninotto mentioned this pull request Mar 5, 2020
Closed
@amayatsky
Copy link

Is it a good decision to document a getSource(); call and make it an 'official' way to use fields inside the form iterator?
I don't even remember what the getSource() does but I do remember it was some sort of a hack or a work around your framework: #2500 (comment)

@JulienMattiussi
Copy link
Contributor Author

JulienMattiussi commented Mar 5, 2020 •
edited
Loading

No issue with this IMO.
Your workaround works fine.
And as it's the only valuable solution for this need currently, it's better to document it than to let people trying many bad solutions.

By the way, we already use getSource() in the simple examples (i.e. in PostCreate.js)

@JulienMattiussi JulienMattiussi removed the WIP Work In Progress label Mar 5, 2020
This was referenced Apr 10, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Fields are not rendered in arrayinput with simpleformiterator
3 participants
@JulienMattiussi @amayatsky @fzaninotto