Fix incomplete PropTypes definition in FormTab component. #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Mar 10, 2020
fzaninotto
requested changes
Mar 18, 2020
fzaninotto
requested changes
Mar 18, 2020
|
The multiple comments on this PR show me that you haven't tested the code. I suggest you add unit or integration tests. |
|
Ok. Could you give me a basic idea of a test regarding the check of the propTypes. |
|
Add a test case in the FormTab unit case where you pass all possible props to the TabbedForm (margin, variant, etc), and check that there is no warning when it runs. |
WiXSL
force-pushed
the
fix-proptypes-formtab
branch
from
8ca7050
to
7f213f0
Compare
added 7 commits
April 17, 2020 11:22
WiXSL
force-pushed
the
fix-proptypes-formtab
branch
from
c7d365f
to
ff8ec36
Compare
fzaninotto
approved these changes
Apr 20, 2020
|
Thanks! |
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.