Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix useGetList after delete when using string identifiers #4575

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

fzaninotto
Copy link
Member

When using string identifiers and an inline delete undoable in a list, once the undo period ends, the getList following the delete threw the following error:

An error occurred while selecting the store state: Cannot read property 'id' of undefined.

This is due to a combination of 2 bugs (one hiding the other) that this PR fixes.

@fzaninotto fzaninotto added this to the 3.3.3 milestone Mar 24, 2020
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djhi djhi merged commit faba3df into master Mar 24, 2020
@djhi djhi deleted the fix-string-id-delete-in-list branch March 24, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants