Convert products demo example into typescript #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
May 4, 2020
| @@ -75,6 +83,7 @@ const LoadedGridList = ({ ids, data, basePath, width }) => { | |||
| > | |||
| {ids.map(id => ( | |||
| <GridListTile | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
It seems another attempt was done at migrating this file (see #4592). Would you mind collaborating with the author of that PR instead of including GridList in your PR?
|
Now that #4516 is merged, can you please rebase your PR to make your changes more apparent? |
|
@fzaninotto sorry I forgot to mention you after rebase I think this is ready for review, should I remove GridList from this PR? |
|
Yes, please remove GridList and share your efforts on #4592 for that component. |
fzaninotto
requested changes
May 13, 2020
fzaninotto
requested changes
May 25, 2020
examples/demo/src/types.ts
Outdated
| @@ -73,6 +73,7 @@ export interface FieldProps<T extends Record = Record> { | |||
| record?: T; | |||
| source?: string; | |||
| basePath?: string; | |||
| resource: string; | |||
There was a problem hiding this comment.
should be optional as it's injected by react-admin
There was a problem hiding this comment.
fixed in #4847
fzaninotto
approved these changes
May 27, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this depends on #4516, refs #4505