Change to use length of values with useEffect in AutocompleteArrayInput #5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as if you spread values when this is nothing in values, the array passed to useEffect will have 1 entry. when there is a something in values, the array passed to useEffect will have 2 entries. By using lenghth, there are always 2 entries in the array
as this will ensure the second parameter to useMemo is consistent in length
djhi
reviewed
Jul 27, 2020
as this ensures if the size doesn't change, but the values do the update fires Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Luwangel
approved these changes
Aug 4, 2020
Luwangel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as if you spread values when this is nothing in values, the second parameter to useEffect will have 1 entry.
when there is a something in values, the second parameter to useEffect will have 2 entries. By using lenghth,
there are always 2 entries in the array
Closes #4724