Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Placeholder component className value order #5109

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fix Placeholder component className value order #5109

merged 1 commit into from
Aug 4, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Aug 4, 2020

No description provided.

@djhi
Copy link
Contributor

djhi commented Aug 4, 2020

Would you mind explaining why it is an issue ?

@WiXSL
Copy link
Contributor Author

WiXSL commented Aug 4, 2020

Just for consistency since is the only component that has that className prop order.

fzaninotto
fzaninotto approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we had an order convention for class names. It's a bikeshedding PR, but since you've done the work, we can merge it!

@fzaninotto fzaninotto merged commit d4c016e into marmelab:master Aug 4, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.7.2 milestone Aug 4, 2020
@fzaninotto fzaninotto changed the title Fix Placeholder component className prop Fix Placeholder component className value order Aug 4, 2020
@WiXSL WiXSL deleted the fix-classes branch August 4, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WiXSL @djhi @fzaninotto