Add ability to disable the Empty Page in List #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luwangel
reviewed
Aug 18, 2020
| @@ -100,7 +100,7 @@ export const ListView: FC<ListViewProps> = props => { | |||
| {...sanitizeRestProps(rest)} | |||
| > | |||
| <Title title={title} defaultTitle={defaultTitle} /> | |||
| {shouldRenderEmptyPage | |||
| {shouldRenderEmptyPage && empty !== false | |||
There was a problem hiding this comment.
Why not update the shouldRenderEmptyPage method to use the empty prop?
There was a problem hiding this comment.
Because of Typescript ;)
djhi
requested changes
Aug 18, 2020
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
djhi
approved these changes
Aug 18, 2020
fzaninotto
requested changes
Aug 19, 2020
|
Review applied |
fzaninotto
approved these changes
Aug 19, 2020
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5158
It's sometimes useful to be able to display an empty list instead of displaying a special "empty page" when there's no data to display.
So, here is a small change that allows to display an empty page when the list is empty.