Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass BooleanField custom icons to show as values #5281

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Add ability to pass BooleanField custom icons to show as values #5281

merged 1 commit into from
Sep 21, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Sep 21, 2020 •
edited by Luwangel
Loading

Implements #5283

djhi
djhi approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@djhi djhi added this to the 3.9.0 milestone Sep 21, 2020
@fzaninotto fzaninotto closed this Sep 21, 2020
@fzaninotto
Copy link
Member

Sorry, this was closed automatically by GitHub when I merged the next branch into master. I'm reopening it.

@fzaninotto fzaninotto reopened this Sep 21, 2020
Luwangel
Luwangel approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Luwangel Luwangel changed the base branch from next to master September 21, 2020 14:14
@Luwangel Luwangel merged commit cdb4764 into marmelab:master Sep 21, 2020
@WiXSL WiXSL deleted the booleanfield-icons branch September 21, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WiXSL @fzaninotto @djhi @Luwangel