Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation of the SaveButton when customizing the Toolbar #5285

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

Luwangel
Copy link
Contributor

Fixes #5220

The documentation about the <SaveButton> disable mechanism is confusing when the <Toolbar> is customized. So I added an explanation and an example about how to restore this mechanism.

Todo

  • Improve the documentation of the <SaveButton> when customizing the <Toolbar>

@Luwangel Luwangel added the RFR Ready For Review label Sep 21, 2020
@djhi djhi added this to the 3.9.0 milestone Sep 23, 2020
@djhi djhi merged commit 7f13933 into master Sep 23, 2020
@djhi djhi deleted the fix-documentation branch September 23, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SaveButton disabled behavior inconsistent with custom toolbar documentation
2 participants