Fix TabbedShowLayout resolves path incorrectly if first tab is null #5312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Sep 28, 2020
|
|
||
| <Divider /> | ||
| <div className={classes.content}> | ||
| {Children.map(children, (tab, index) => | ||
| tab && isValidElement(tab) ? ( | ||
| {Children.map(finalChildren, (tab, index) => { |
There was a problem hiding this comment.
here, you can use the regular children, right? This avoids having a different value at each render, and defeating pure component optimizations.
There was a problem hiding this comment.
I don't understand, if I go back to using Children.map(children, (tab, index) => the tests won't pass.
Should I filter nonNullChildren with useMemo?
added 2 commits
September 28, 2020 10:17
fzaninotto
approved these changes
Oct 1, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5294